Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: store query timeout as a java.time.Duration #1865

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

olavloite
Copy link
Collaborator

Store the query timeout internally as a java.time.Duration, so we can use a smaller unit for testing. This again allows us to enable the timeout tests by default.

Store the query timeout internally as a java.time.Duration, so we can use a
smaller unit for testing. This again allows us to enable the timeout tests
by default.
@olavloite olavloite requested review from a team as code owners December 14, 2024 12:49
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner-jdbc API. labels Dec 14, 2024
@olavloite olavloite requested a review from rayudu3745 December 14, 2024 12:49
@olavloite olavloite merged commit 8f587cf into main Dec 19, 2024
22 checks passed
@olavloite olavloite deleted the use-duration-for-timeout branch December 19, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants