-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: added regional endpoint sample for datastore #1043
Open
shweta345
wants to merge
13
commits into
googleapis:main
Choose a base branch
from
shweta345:regional-endpoint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f8f37af
chore: added regional endpoint sample for datastore
shweta345 3c3b655
chore: added regional endpoint sample for datastore
shweta345 117c621
revert changes to QuickstartSample.java
jlara310 0bcafad
Refactor test. Move validation operations to the test.
jlara310 e0eda8e
Use correct api endpoint.
jlara310 ec72ff5
remove typo
jlara310 2cdaf5d
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] eeff0ae
Refactor test
jlara310 dc41325
Use a unique ID for the test entity
jlara310 52c15d5
Use UUID for test entity. Fix linting errors.
jlara310 c446023
Fix linting error in javadoc @return comment
jlara310 66fd56a
Fix order of imports in RegionalEndpointIT
jlara310 99f1d99
Merge branch 'main' into regional-endpoint
meredithslota File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
samples/snippets/src/main/java/com/example/datastore/RegionalEndpoint.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
/* | ||
* Copyright 2023 Google Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.example.datastore; | ||
|
||
// Imports the Google Cloud client library | ||
// [START datastore_regional_endpoint] | ||
|
||
import com.google.cloud.datastore.Datastore; | ||
import com.google.cloud.datastore.DatastoreOptions; | ||
|
||
public class RegionalEndpoint { | ||
|
||
public Datastore createClient() throws Exception { | ||
// Instantiates a client | ||
DatastoreOptions options = | ||
DatastoreOptions.newBuilder().setHost("https://nam5-datastore.googleapis.com").build(); | ||
Datastore datastore = options.getService(); | ||
return datastore; | ||
} | ||
} | ||
// [END datastore_regional_endpoint] |
75 changes: 75 additions & 0 deletions
75
samples/snippets/src/test/java/com/example/datastore/RegionalEndpointIT.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
/* | ||
* Copyright 2023 Google Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.example.datastore; | ||
|
||
import static org.junit.Assert.assertEquals; | ||
|
||
import com.google.cloud.datastore.Datastore; | ||
import com.google.cloud.datastore.Entity; | ||
import com.google.cloud.datastore.Key; | ||
import org.junit.Before; | ||
import org.junit.Test; | ||
import org.junit.runner.RunWith; | ||
import org.junit.runners.JUnit4; | ||
|
||
/** | ||
* Tests for quickstart sample. | ||
*/ | ||
@RunWith(JUnit4.class) | ||
@SuppressWarnings("checkstyle:abbreviationaswordinname") | ||
public class RegionalEndpointIT { | ||
|
||
private static RegionalEndpoint regionalEndpoint; | ||
|
||
private static final void deleteTestEntity(Datastore datastore) { | ||
String kind = "Task"; | ||
String name = "sampletask1"; | ||
Key taskKey = datastore.newKeyFactory().setKind(kind).newKey(name); | ||
datastore.delete(taskKey); | ||
} | ||
|
||
@Before | ||
public void setUp() { | ||
regionalEndpoint = new RegionalEndpoint(); | ||
} | ||
|
||
@Test | ||
public void testRegionalEndpoint() throws Exception { | ||
Datastore datastoreWithEndpoint = regionalEndpoint.createClient(); | ||
|
||
// run a few operations with the client | ||
deleteTestEntity(datastoreWithEndpoint); | ||
// The kind for the new entity | ||
String kind = "Task"; | ||
// The name/ID for the new entity | ||
String name = "regionalEndpointClient50720906"; | ||
// The Cloud Datastore key for the new entity | ||
Key taskKey = datastoreWithEndpoint.newKeyFactory().setKind(kind).newKey(name); | ||
|
||
// Prepares the new entity | ||
Entity task = Entity.newBuilder(taskKey).set("description", "Buy milk").build(); | ||
|
||
// Saves the entity | ||
datastoreWithEndpoint.put(task); | ||
|
||
// Retrieve entity | ||
Entity retrieved = datastoreWithEndpoint.get(taskKey); | ||
|
||
assertEquals(task, retrieved); | ||
deleteTestEntity(datastoreWithEndpoint); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not quite what I had in mind. See https://docs.oracle.com/javase/8/docs/api/java/util/UUID.html
You probably want to create one once and use it in both the
testRegionalEndpoint()
anddeleteTestEntity()
methods.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thank you for explaining. Updated to use UUID. Does a UUID.randomUUID() make sense here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done