Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update test to use prefix generator for tableId so it'll get cl… #2458

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Jan 6, 2025

…eaned up

Test table ids generated from prefix generator are cleaned up by https://github.com/googleapis/java-bigtable/blob/main/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/test_helpers/env/TestEnvRule.java#L148. Updating SampleRowsIT test to use PrefixGenerator in case the delete failed.

@mutianf mutianf requested review from a team as code owners January 6, 2025 15:48
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Jan 6, 2025
@mutianf mutianf added the automerge Merge the pull request once unit tests and other checks pass. label Jan 6, 2025
@gcf-merge-on-green gcf-merge-on-green bot merged commit 2ccd6fd into googleapis:main Jan 6, 2025
19 of 20 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 6, 2025
@mutianf mutianf deleted the cleanup-test branch January 6, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants