Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make build time only dependencies optional pom.xml #3281

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johnpoth
Copy link

@johnpoth johnpoth commented May 6, 2024

It would be cool if dependencies only needed at build time were marked as optional. That would reduce the amount of dependencies that are pulled when depending on this project. Thanks !

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3280 ☕️

If you write sample code, please follow the samples format.

@johnpoth johnpoth requested review from a team as code owners May 6, 2024 12:44
Copy link

google-cla bot commented May 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/java-bigquery API. labels May 6, 2024
@johnpoth
Copy link
Author

johnpoth commented May 7, 2024

@google-cla signed ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make build time only dependencies optional
1 participant