-
Notifications
You must be signed in to change notification settings - Fork 55
feat(auth): add external account url sourced credentials #2217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 17 commits
57b4264
f11ee98
b2ba552
055990d
84b81e0
42e989f
fca8675
ad56efd
041003b
39c0e18
06534a4
3b84492
c859658
e8d2371
99c140b
6917c63
e059453
9b434fe
80afb38
1d8ea19
e4601c2
7b62a0a
766cbdf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -11,6 +11,21 @@ env GOOGLE_CLOUD_PROJECT=rust-auth-testing \ | |||||||||||||||
cargo test --features run-integration-tests -p auth-integration-tests | ||||||||||||||||
``` | ||||||||||||||||
|
||||||||||||||||
### Workload Identity integration tests | ||||||||||||||||
|
||||||||||||||||
Those integration tests requires more complex set up to run, like running from | ||||||||||||||||
an Azure/AWS VM and having Workload Identity Pools set up. For now we are only | ||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||
run those tests locally and under a feature (`run-byoid-integration-tests`). | ||||||||||||||||
Some extra environment variables with the workload identity pool configuration | ||||||||||||||||
are required to run the tests. | ||||||||||||||||
|
||||||||||||||||
```sh | ||||||||||||||||
env GOOGLE_CLOUD_PROJECT=cloud-sdk-auth-test-project \ | ||||||||||||||||
env GOOGLE_WORKLOAD_IDENTITY_SERVICE_ACCOUNT=<path-to-service-account> \ | ||||||||||||||||
env GOOGLE_WORKLOAD_IDENTITY_OIDC_AUDIENCE=//iam.googleapis.com/projects/<PROJECT_ID>/locations/global/workloadIdentityPools/<WORKLOAD_IDENTITY_POOL_ID>/providers/<WORKLOAD_IDENTITY_PROVIDER_ID> \ | ||||||||||||||||
cargo test run_workload_ --features run-integration-tests --features run-byoid-integration-tests -p auth-integration-tests | ||||||||||||||||
Comment on lines
+23
to
+26
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
it is also sad to have the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Or maybe the test program should consume |
||||||||||||||||
``` | ||||||||||||||||
|
||||||||||||||||
#### Rotating the service account key | ||||||||||||||||
|
||||||||||||||||
Service account keys expire after 90 days, due to our org policy. | ||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.