Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: [gkemulticloud] fix comments of existing field #5900

Merged
merged 4 commits into from
Jan 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/google-cloud-gkemulticloud/.jsdoc.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2024 Google LLC
// Copyright 2025 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -40,7 +40,7 @@ module.exports = {
includePattern: '\\.js$'
},
templates: {
copyright: 'Copyright 2024 Google LLC',
copyright: 'Copyright 2025 Google LLC',
includeDate: false,
sourceFiles: false,
systemName: '@google-cloud/gkemulticloud',
Expand Down
2 changes: 1 addition & 1 deletion packages/google-cloud-gkemulticloud/.mocharc.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2024 Google LLC
// Copyright 2025 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion packages/google-cloud-gkemulticloud/.prettierrc.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2024 Google LLC
// Copyright 2025 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,24 @@ message AttachedCluster {
// Optional. Security Posture configuration for this cluster.
SecurityPostureConfig security_posture_config = 26
[(google.api.field_behavior) = OPTIONAL];

// Optional. Input only. Tag keys/values directly bound to this resource.
//
// Tag key must be specified in the format <tag namespace>/<tag key name>
// where the tag namespace is the ID of the organization or name of the
// project that the tag key is defined in.
// The short name of a tag key or value can have a maximum length of 256
// characters. The permitted character set for the short name includes UTF-8
// encoded Unicode characters except single quotes ('), double quotes ("),
// backslashes (\), and forward slashes (/).
//
// See
// [Tags](https://cloud.google.com/resource-manager/docs/tags/tags-overview)
// for more details on Google Cloud Platform tags.
map<string, string> tags = 27 [
(google.api.field_behavior) = OPTIONAL,
(google.api.field_behavior) = INPUT_ONLY
];
}

// Configuration related to the cluster RBAC settings.
Expand Down Expand Up @@ -261,6 +279,10 @@ message AttachedProxyConfig {
// The Kubernetes Secret resource that contains the HTTP(S) proxy
// configuration. The secret must be a JSON encoded proxy configuration
// as described in
// https://cloud.google.com/kubernetes-engine/multi-cloud/docs/attached/eks/how-to/use-a-proxy#configure-proxy-support
// for EKS clusters and
// https://cloud.google.com/kubernetes-engine/multi-cloud/docs/attached/aks/how-to/use-a-proxy#configure-proxy-support
// for AKS clusters.
KubernetesSecret kubernetes_secret = 1;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,7 @@ message UpdateAttachedClusterRequest {
// * `proxy_config.kubernetes_secret.name`.
// * `proxy_config.kubernetes_secret.namespace`.
// * `security_posture_config.vulnerability_mode`
// * `monitoring_config.cloud_monitoring_config.enabled`
google.protobuf.FieldMask update_mask = 3
[(google.api.field_behavior) = REQUIRED];
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,10 @@ message OperationMetadata {

// Output only. Identifies whether it has been requested cancellation
// for the operation. Operations that have successfully been cancelled
// have [Operation.error][] value with a
// [google.rpc.Status.code][google.rpc.Status.code] of 1, corresponding to
// `Code.CANCELLED`.
// have
// [google.longrunning.Operation.error][google.longrunning.Operation.error]
// value with a [google.rpc.Status.code][google.rpc.Status.code] of 1,
// corresponding to `Code.CANCELLED`.
bool requested_cancellation = 6 [(google.api.field_behavior) = OUTPUT_ONLY];
}

Expand Down Expand Up @@ -245,6 +246,10 @@ message LoggingComponentConfig {
message MonitoringConfig {
// Enable Google Cloud Managed Service for Prometheus in the cluster.
ManagedPrometheusConfig managed_prometheus_config = 2;

// Optionally enable GKE metrics.
// Only for Attached Clusters.
CloudMonitoringConfig cloud_monitoring_config = 4;
}

// ManagedPrometheusConfig defines the configuration for
Expand All @@ -254,6 +259,15 @@ message ManagedPrometheusConfig {
bool enabled = 1;
}

// CloudMonitoringConfig defines the configuration for
// built-in Cloud Logging and Monitoring.
// Only for Attached Clusters.
message CloudMonitoringConfig {
// Enable GKE-native logging and metrics.
// Only for Attached Clusters.
optional bool enabled = 1;
}

// Configuration for Binary Authorization.
message BinaryAuthorization {
// Binary Authorization mode of operation.
Expand Down
114 changes: 113 additions & 1 deletion packages/google-cloud-gkemulticloud/protos/protos.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading