-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(storage): monitored resource detection #11197
Merged
+404
−198
Merged
Changes from 20 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
19d99e5
fix(storage): populate monitored resource correctly
frankyn 004f8f6
refactor with additional integration tests
frankyn 09fc863
refactor initialization of metricsContext
frankyn be04e92
remove exporter experimental option and add manual reader for tests
frankyn ba05e27
Merge branch 'main' into fix-mr-storage
frankyn 256b835
go mod tidy
frankyn 1e2cc6f
dependency inject gcp detector for testing
frankyn 34d53cb
Merge branch 'main' into fix-mr-storage
frankyn b15c80a
Merge branch 'main' into fix-mr-storage
frankyn bb67dd3
revert removal of metricExporter option
frankyn 7e4095b
revert changes to metricExporter option tests
frankyn 751b810
use struct embedding
frankyn 3906ab7
pass in resource correctly to exporter
frankyn 1cdfdef
Merge branch 'main' into fix-mr-storage
frankyn 34e04cb
update test using resource value
frankyn 6308f2f
add tests checking resource values
frankyn b96a540
Merge branch 'main' into fix-mr-storage
frankyn 585b72d
add option to disable exporter in unit tests
frankyn 7749f7a
Merge branch 'main' into fix-mr-storage
frankyn d503aed
Merge branch 'main' into fix-mr-storage
frankyn 7547a15
Merge branch 'main' into fix-mr-storage
frankyn 3de98fc
address feedback
frankyn 728feae
use project-id not project_id...
frankyn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have a bug for this?