Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [Google.Cloud.GkeMultiCloud.V1] added support for optionally disabling built-in GKE metrics #14030

Merged
merged 1 commit into from
Dec 21, 2024
Merged

feat: [Google.Cloud.GkeMultiCloud.V1] added support for optionally disabling built-in GKE metrics #14030

merged 1 commit into from
Dec 21, 2024

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Dec 20, 2024

  • Regenerate this pull request now.

feat: added tag bindings support for Attached Clusters
docs: updated comments of existing fields

PiperOrigin-RevId: 708397945

Source-Link: googleapis/googleapis@09b3c83

Source-Link: https://github.com/googleapis/googleapis-gen/commit/822c2acaf7af07dfbb7f86ce2e2e0f2e744b72e5
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuR2tlTXVsdGlDbG91ZC5WMS8uT3dsQm90LnlhbWwiLCJoIjoiODIyYzJhY2FmN2FmMDdkZmJiN2Y4NmNlMmUyZTBmMmU3NDRiNzJlNSJ9

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 20, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2024
@github-actions GitHub Actions
Copy link

Pull request diff results
OwlBot post-processor has not run: failing diff.

@gcf-owl-bot
feat: added support for optionally disabling built-in GKE metrics
ebf6c99 
feat: added tag bindings support for Attached Clusters
docs: updated comments of existing fields

PiperOrigin-RevId: 708397945

Source-Link: googleapis/googleapis@09b3c83

Source-Link: googleapis/googleapis-gen@822c2ac
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuR2tlTXVsdGlDbG91ZC5WMS8uT3dsQm90LnlhbWwiLCJoIjoiODIyYzJhY2FmN2FmMDdkZmJiN2Y4NmNlMmUyZTBmMmU3NDRiNzJlNSJ9
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review December 20, 2024 23:32
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner December 20, 2024 23:32
@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-apis-Google_Cloud_GkeMultiCloud_V1 branch from 82bff74 to ebf6c99 Compare December 20, 2024 23:32
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner December 20, 2024 23:32
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2024
@github-actions GitHub Actions
Copy link

Pull request diff results
Finding changes in Google.Cloud.GkeMultiCloud.V1...
Comparing old and new versions (by source)
Minor changes:
Class 'AttachedCluster'; property 'MapField<String, String> Tags { get; }' added.
Class 'AttachedCluster'; constant 'System.Int32 Google.Cloud.GkeMultiCloud.V1.AttachedCluster::TagsFieldNumber' added.
Class 'CloudMonitoringConfig' added.
Class 'MonitoringConfig'; property 'CloudMonitoringConfig CloudMonitoringConfig { get; set; }' added.
Class 'MonitoringConfig'; constant 'System.Int32 Google.Cloud.GkeMultiCloud.V1.MonitoringConfig::CloudMonitoringConfigFieldNumber' added.

Diff level: Minor

Comparing with previous NuGet package
Checking compatibility for Google.Cloud.GkeMultiCloud.V1 version 2.7.0
Differences from 2.7.0
Minor changes:
Class 'AttachedCluster'; property 'MapField<String, String> Tags { get; }' added.
Class 'AttachedCluster'; constant 'System.Int32 Google.Cloud.GkeMultiCloud.V1.AttachedCluster::TagsFieldNumber' added.
Class 'CloudMonitoringConfig' added.
Class 'MonitoringConfig'; property 'CloudMonitoringConfig CloudMonitoringConfig { get; set; }' added.
Class 'MonitoringConfig'; constant 'System.Int32 Google.Cloud.GkeMultiCloud.V1.MonitoringConfig::CloudMonitoringConfigFieldNumber' added.

Diff level: Minor

Finished comparisons for Google.Cloud.GkeMultiCloud.V1

@amanda-tarafa amanda-tarafa merged commit 3170840 into main Dec 21, 2024
12 checks passed
@amanda-tarafa amanda-tarafa deleted the owl-bot-copy-apis-Google_Cloud_GkeMultiCloud_V1 branch December 21, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanda-tarafa amanda-tarafa amanda-tarafa approved these changes

Assignees
No one assigned
Labels
kokoro:force-run Add this label to force Kokoro to re-run the tests. owl-bot-copy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amanda-tarafa