feat: Allow a container-clean api-path of "none" #14012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When provided "none", the container should clean just non-API-specific files.
amanda-tarafa
approved these changes
Dec 16, 2024
| @@ -25,6 +25,7 @@ namespace Google.Cloud.Tools.ReleaseManager.ContainerCommands; | |||
| /// - repo-root: path to the root of the clone | |||
| /// - api-path: path to the API to clean generated files from, e.g. google/cloud/functions/v2 | |||
| /// This is optional; when omitted, all configured APIs are cleaned. | |||
| /// The special value of "none" means "clean non-API-specific files only". | |||
There was a problem hiding this comment.
For later: Wondering if api-path should be required, with a couple of magic values "none" and "all"?
Alternative, with hide that from the surface and have three commands: clean-api, clean-all, clean-common?
Definetely something for another PR though.
There was a problem hiding this comment.
You read my mind (first option): googleapis/generator#67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When provided "none", the container should clean just non-API-specific files.
(This is needed for the configure CLI command.)