Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: [Google.Shopping.Merchant.Products.V1Beta] Changed repeated flag of an existing field gtin in message .google.shopping.merchant.products.v1beta.Attributes #13966

Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix!: [Google.Shopping.Merchant.Products.V1Beta] Changed repeated flag of an existing field gtin in message .google.shopping.merchant.products.v1beta.Attributes #13966

merged 1 commit into from
Dec 9, 2024

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Dec 9, 2024

  • Regenerate this pull request now.

fix!: An existing field gtin is moved out of oneof in message .google.shopping.merchant.products.v1beta.Attributes
docs: A comment for message ProductInput is changed
docs: A comment for field name in message .google.shopping.merchant.products.v1beta.ProductInput is changed
docs: A comment for field name in message .google.shopping.merchant.products.v1beta.DeleteProductInputRequest is changed
docs: A comment for message Product is changed
docs: A comment for field name in message .google.shopping.merchant.products.v1beta.Product is changed
docs: A comment for field name in message .google.shopping.merchant.products.v1beta.GetProductRequest is changed
docs: A comment for field page_size in message .google.shopping.merchant.products.v1beta.ListProductsRequest is changed
docs: A comment for field gtin in message .google.shopping.merchant.products.v1beta.Attributes is changed
docs: A comment for field tax_category in message .google.shopping.merchant.products.v1beta.Attributes is changed
docs: A comment for field min_handling_time in message .google.shopping.merchant.products.v1beta.Shipping is changed
docs: A comment for field max_handling_time in message .google.shopping.merchant.products.v1beta.Shipping is changed
docs: A comment for field min_transit_time in message .google.shopping.merchant.products.v1beta.Shipping is changed
docs: A comment for field max_transit_time in message .google.shopping.merchant.products.v1beta.Shipping is changed
feat: A new field member_price_effective_date is added to message .google.shopping.merchant.products.v1beta.LoyaltyProgram
feat: A new field shipping_label is added to message .google.shopping.merchant.products.v1beta.LoyaltyProgram

PiperOrigin-RevId: 704281512

Source-Link: googleapis/googleapis@0f1beb9

Source-Link: https://github.com/googleapis/googleapis-gen/commit/5429d7d40b248ad0347e916defee17ba51164011
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuU2hvcHBpbmcuTWVyY2hhbnQuUHJvZHVjdHMuVjFCZXRhLy5Pd2xCb3QueWFtbCIsImgiOiI1NDI5ZDdkNDBiMjQ4YWQwMzQ3ZTkxNmRlZmVlMTdiYTUxMTY0MDExIn0=

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

Pull request diff results
OwlBot post-processor has not run: failing diff.

@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 9, 2024
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review December 9, 2024 18:17
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner December 9, 2024 18:17
@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-apis-Google_Shopping_Merchant_Products_V1Beta branch from e2ca0c0 to 051b9e4 Compare December 9, 2024 18:17
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner December 9, 2024 18:17
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 9, 2024
@gcf-owl-bot
fix!: Changed repeated flag of an existing field gtin in message `.…
e6b1c1c 
…google.shopping.merchant.products.v1beta.Attributes`

fix!: An existing field `gtin` is moved out of oneof in message `.google.shopping.merchant.products.v1beta.Attributes`
docs: A comment for message `ProductInput` is changed
docs: A comment for field `name` in message `.google.shopping.merchant.products.v1beta.ProductInput` is changed
docs: A comment for field `name` in message `.google.shopping.merchant.products.v1beta.DeleteProductInputRequest` is changed
docs: A comment for message `Product` is changed
docs: A comment for field `name` in message `.google.shopping.merchant.products.v1beta.Product` is changed
docs: A comment for field `name` in message `.google.shopping.merchant.products.v1beta.GetProductRequest` is changed
docs: A comment for field `page_size` in message `.google.shopping.merchant.products.v1beta.ListProductsRequest` is changed
docs: A comment for field `gtin` in message `.google.shopping.merchant.products.v1beta.Attributes` is changed
docs: A comment for field `tax_category` in message `.google.shopping.merchant.products.v1beta.Attributes` is changed
docs: A comment for field `min_handling_time` in message `.google.shopping.merchant.products.v1beta.Shipping` is changed
docs: A comment for field `max_handling_time` in message `.google.shopping.merchant.products.v1beta.Shipping` is changed
docs: A comment for field `min_transit_time` in message `.google.shopping.merchant.products.v1beta.Shipping` is changed
docs: A comment for field `max_transit_time` in message `.google.shopping.merchant.products.v1beta.Shipping` is changed
feat: A new field `member_price_effective_date` is added to message `.google.shopping.merchant.products.v1beta.LoyaltyProgram`
feat: A new field `shipping_label` is added to message `.google.shopping.merchant.products.v1beta.LoyaltyProgram`

PiperOrigin-RevId: 704281512

Source-Link: googleapis/googleapis@0f1beb9

Source-Link: googleapis/googleapis-gen@5429d7d
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuU2hvcHBpbmcuTWVyY2hhbnQuUHJvZHVjdHMuVjFCZXRhLy5Pd2xCb3QueWFtbCIsImgiOiI1NDI5ZDdkNDBiMjQ4YWQwMzQ3ZTkxNmRlZmVlMTdiYTUxMTY0MDExIn0=
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 9, 2024
@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-apis-Google_Shopping_Merchant_Products_V1Beta branch from 051b9e4 to e6b1c1c Compare December 9, 2024 18:17
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

Pull request diff results
Finding changes in Google.Shopping.Merchant.Products.V1Beta...
Comparing old and new versions (by source)
Major changes:
Class 'Attributes'; method 'void ClearGtin()' removed.
Class 'Attributes'; property 'Boolean HasGtin { get; }' removed.
Class 'Attributes'; property 'String Gtin { get; set; }' setter access modifer changed from 'public' to ''.
Class 'Attributes'; property 'String Gtin { get; set; }' return type changed to 'RepeatedField'.

Minor changes:
Class 'LoyaltyProgram'; method 'void ClearShippingLabel()' added.
Class 'LoyaltyProgram'; property 'Interval MemberPriceEffectiveDate { get; set; }' added.
Class 'LoyaltyProgram'; property 'Boolean HasShippingLabel { get; }' added.
Class 'LoyaltyProgram'; property 'String ShippingLabel { get; set; }' added.
Class 'LoyaltyProgram'; constant 'System.Int32 Google.Shopping.Merchant.Products.V1Beta.LoyaltyProgram::MemberPriceEffectiveDateFieldNumber' added.
Class 'LoyaltyProgram'; constant 'System.Int32 Google.Shopping.Merchant.Products.V1Beta.LoyaltyProgram::ShippingLabelFieldNumber' added.

Diff level: Major

Comparing with previous NuGet package
Checking compatibility for Google.Shopping.Merchant.Products.V1Beta version 1.0.0-beta01
Differences from 1.0.0-beta01
Major changes:
Class 'Attributes'; method 'void ClearGtin()' removed.
Class 'Attributes'; property 'Boolean HasGtin { get; }' removed.
Class 'Attributes'; property 'String Gtin { get; set; }' setter access modifer changed from 'public' to ''.
Class 'Attributes'; property 'String Gtin { get; set; }' return type changed to 'RepeatedField'.

Minor changes:
Class 'LoyaltyProgram'; method 'void ClearShippingLabel()' added.
Class 'LoyaltyProgram'; property 'Interval MemberPriceEffectiveDate { get; set; }' added.
Class 'LoyaltyProgram'; property 'Boolean HasShippingLabel { get; }' added.
Class 'LoyaltyProgram'; property 'String ShippingLabel { get; set; }' added.
Class 'LoyaltyProgram'; constant 'System.Int32 Google.Shopping.Merchant.Products.V1Beta.LoyaltyProgram::MemberPriceEffectiveDateFieldNumber' added.
Class 'LoyaltyProgram'; constant 'System.Int32 Google.Shopping.Merchant.Products.V1Beta.LoyaltyProgram::ShippingLabelFieldNumber' added.

Diff level: Major

Finished comparisons for Google.Shopping.Merchant.Products.V1Beta

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

Pull request diff results
Finding changes in Google.Shopping.Merchant.Products.V1Beta...
Comparing old and new versions (by source)
Major changes:
Class 'Attributes'; method 'void ClearGtin()' removed.
Class 'Attributes'; property 'Boolean HasGtin { get; }' removed.
Class 'Attributes'; property 'String Gtin { get; set; }' setter access modifer changed from 'public' to ''.
Class 'Attributes'; property 'String Gtin { get; set; }' return type changed to 'RepeatedField'.

Minor changes:
Class 'LoyaltyProgram'; method 'void ClearShippingLabel()' added.
Class 'LoyaltyProgram'; property 'Interval MemberPriceEffectiveDate { get; set; }' added.
Class 'LoyaltyProgram'; property 'Boolean HasShippingLabel { get; }' added.
Class 'LoyaltyProgram'; property 'String ShippingLabel { get; set; }' added.
Class 'LoyaltyProgram'; constant 'System.Int32 Google.Shopping.Merchant.Products.V1Beta.LoyaltyProgram::MemberPriceEffectiveDateFieldNumber' added.
Class 'LoyaltyProgram'; constant 'System.Int32 Google.Shopping.Merchant.Products.V1Beta.LoyaltyProgram::ShippingLabelFieldNumber' added.

Diff level: Major

Comparing with previous NuGet package
Checking compatibility for Google.Shopping.Merchant.Products.V1Beta version 1.0.0-beta01
Differences from 1.0.0-beta01
Major changes:
Class 'Attributes'; method 'void ClearGtin()' removed.
Class 'Attributes'; property 'Boolean HasGtin { get; }' removed.
Class 'Attributes'; property 'String Gtin { get; set; }' setter access modifer changed from 'public' to ''.
Class 'Attributes'; property 'String Gtin { get; set; }' return type changed to 'RepeatedField'.

Minor changes:
Class 'LoyaltyProgram'; method 'void ClearShippingLabel()' added.
Class 'LoyaltyProgram'; property 'Interval MemberPriceEffectiveDate { get; set; }' added.
Class 'LoyaltyProgram'; property 'Boolean HasShippingLabel { get; }' added.
Class 'LoyaltyProgram'; property 'String ShippingLabel { get; set; }' added.
Class 'LoyaltyProgram'; constant 'System.Int32 Google.Shopping.Merchant.Products.V1Beta.LoyaltyProgram::MemberPriceEffectiveDateFieldNumber' added.
Class 'LoyaltyProgram'; constant 'System.Int32 Google.Shopping.Merchant.Products.V1Beta.LoyaltyProgram::ShippingLabelFieldNumber' added.

Diff level: Major

Finished comparisons for Google.Shopping.Merchant.Products.V1Beta

@jskeet jskeet merged commit da4a57a into main Dec 9, 2024
11 checks passed
@jskeet jskeet deleted the owl-bot-copy-apis-Google_Shopping_Merchant_Products_V1Beta branch December 9, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet approved these changes

Assignees
No one assigned
Labels
kokoro:force-run Add this label to force Kokoro to re-run the tests. owl-bot-copy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jskeet