docs(quickstart): Replace deprecated RPC in the sample code #14545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
samples
cuiy0006
changed the title
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
dbolduc
approved these changes
Jul 23, 2024
cuiy0006
force-pushed
the
edgenetwork-quickstart-replace-deprecated
branch
from
5b0d8f8 to
e3a79e3
Compare
devbww
reviewed
Jul 23, 2024
google/cloud/edgenetwork/README.md
Outdated
Comment on lines
25
to
26
| if (argc != 4) { | ||
| std::cerr << "Usage: " << argv[0] << " project-id location-id\n"; |
There was a problem hiding this comment.
There is now a mismatch between the requirement and the error message.
Comment on lines
21
to
22
| if (argc != 4) { | ||
| std::cerr << "Usage: " << argv[0] << " project-id location-id\n"; |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14545 +/- ##
=======================================
Coverage 93.59% 93.59%
=======================================
Files 2316 2316
Lines 206915 206915
=======================================
+ Hits 193660 193661 +1
+ Misses 13255 13254 -1 ☔ View full report in Codecov by Sentry. |
scotthart
force-pushed
the
edgenetwork-quickstart-replace-deprecated
branch
from
cd86258 to
c9c2bb1
Compare
scotthart
force-pushed
the
edgenetwork-quickstart-replace-deprecated
branch
from
c9c2bb1 to
f98a30a
Compare
cuiy0006
added a commit
to cuiy0006/google-cloud-cpp
that referenced
this pull request
Jul 23, 2024
…is#14545) * docs(quickstart): Replace deprecated RPC in the sample code * fix format * change error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the deprecated RPC
ListZoneswithListNetworksin the quickstart sample code. The deprecation information is ingoogle/cloud/edgenetwork/v1/service.proto.We don't have a zone in the our test project's test location, so a NOT_FOUND error is expected in the test.
This change is