Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(generator): avoid additional proto files flake #14520

Merged
merged 3 commits into from
Jul 20, 2024

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jul 20, 2024

Related to #14518

Avoid flakes like: https://console.cloud.google.com/cloud-build/builds;region=us-east1/ce904a37-73d0-4e6d-8e41-ce3bb3cba307?project=936212892354

To convince myself that the changes work, and we do not end up with unmaintained files, I deleted the google/cloud/run/v2 directory before regenerating the code.

Which gives me an idea that we could do something like:

# Reset golden files
git grep -l "Generated by the Codegen C++ plugin" generator/integration_tests/golden | xargs rm

# Reset generated libraries
git grep -l "Generated by the Codegen C++ plugin" google/ | xargs rm

to make sure that generated files continue to be tracked by the generator.


This change is Reviewable

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.59%. Comparing base (a86e887) to head (33c1de7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14520   +/-   ##
=======================================
  Coverage   93.58%   93.59%           
=======================================
  Files        2316     2316           
  Lines      207108   207108           
=======================================
+ Hits       193826   193836   +10     
+ Misses      13282    13272   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review July 20, 2024 18:55
@dbolduc dbolduc requested a review from a team as a code owner July 20, 2024 18:55
@dbolduc dbolduc merged commit 78b5332 into googleapis:main Jul 20, 2024
63 checks passed
@dbolduc dbolduc deleted the generator-cloud-run-flake branch July 20, 2024 19:37
cuiy0006 pushed a commit to cuiy0006/google-cloud-cpp that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants