impl: reservoir sample for span events #14407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can only upload 32 events per span to Cloud Trace. Some spans may have a lot more. Use a reservoir sampler to randomly select which events are sent. The first and last event are always preserved because they usually contain something more important than any middle events.
product-auto-label
bot
added
the
samples
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14407 +/- ##
==========================================
- Coverage 93.58% 93.58% -0.01%
==========================================
Files 2313 2313
Lines 206885 206885
==========================================
- Hits 193622 193619 -3
- Misses 13263 13266 +3 ☔ View full report in Codecov by Sentry. |
dbolduc
approved these changes
Jul 1, 2024
coryan
added
cpp: opentelemetry
and removed
samples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can only upload 32 events per span to Cloud Trace. Some spans may
have a lot more. Use a reservoir sampler to randomly select which events
are sent. The first and last event are always preserved because they
usually contain something more important than any middle events.
This change is