Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(storage): remove unused Bazel flag #14398

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jun 28, 2024

This flag sets an environment variable which only has an effect in
integration tests. And the integration tests override the environment
variable.


This change is Reviewable

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.06%. Comparing base (e4ed3a4) to head (bcdcc4a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14398   +/-   ##
=======================================
  Coverage   93.06%   93.06%           
=======================================
  Files        2191     2191           
  Lines      193292   193292           
=======================================
+ Hits       179893   179894    +1     
+ Misses      13399    13398    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This flag sets an environment variable which only has an effect in
integration tests.  And the integration tests override the environment
variable.
@coryan coryan force-pushed the cleanup-storage-remove-bazel-variable branch from 68cdc9a to bcdcc4a Compare June 28, 2024 03:07
@coryan coryan marked this pull request as ready for review June 28, 2024 03:15
@coryan coryan requested a review from a team as a code owner June 28, 2024 03:15
@coryan coryan enabled auto-merge (squash) June 28, 2024 03:15
@coryan coryan merged commit 35310bb into googleapis:main Jun 28, 2024
66 checks passed
@coryan coryan deleted the cleanup-storage-remove-bazel-variable branch June 28, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants