cleanup(storage): fix MOAR IWYU warnings, take 3 (#14544)

googleapis · Jul 23, 2024 · 4acaead · 4acaead
1 parent 7b2867f
commit 4acaead
Show file tree

Hide file tree

Showing 46 changed files with 60 additions and 0 deletions.
diff --git a/google/cloud/storage/async/object_responses.cc b/google/cloud/storage/async/object_responses.cc
@@ -14,6 +14,8 @@
 
 #include "google/cloud/storage/async/object_responses.h"
 #include "google/cloud/storage/internal/async/write_payload_impl.h"
+#include <utility>
+#include <vector>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/async/rewriter.cc b/google/cloud/storage/async/rewriter.cc
@@ -15,6 +15,7 @@
 #include "google/cloud/storage/async/rewriter.h"
 #include "google/cloud/internal/make_status.h"
 #include <memory>
+#include <utility>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/async/writer.cc b/google/cloud/storage/async/writer.cc
@@ -15,6 +15,8 @@
 #include "google/cloud/storage/async/writer.h"
 #include "google/cloud/internal/make_status.h"
 #include <memory>
+#include <string>
+#include <utility>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/benchmarks/aggregate_upload_throughput_benchmark.cc b/google/cloud/storage/benchmarks/aggregate_upload_throughput_benchmark.cc
@@ -28,6 +28,10 @@
 #include "absl/strings/str_format.h"
 #include "absl/time/time.h"
 #include <mutex>
+#include <sstream>
+#include <string>
+#include <utility>
+#include <vector>
 
 namespace {
 using ::google::cloud::testing_util::FormatSize;

diff --git a/google/cloud/storage/benchmarks/async_throughput_benchmark.cc b/google/cloud/storage/benchmarks/async_throughput_benchmark.cc
@@ -32,6 +32,7 @@
 #include <map>
 #include <memory>
 #include <random>
+#include <sstream>
 #include <stdexcept>
 #include <string>
 #include <string_view>

diff --git a/google/cloud/storage/benchmarks/throughput_result_test.cc b/google/cloud/storage/benchmarks/throughput_result_test.cc
@@ -20,6 +20,7 @@
 #include "absl/strings/match.h"
 #include <gmock/gmock.h>
 #include <algorithm>
+#include <sstream>
 #include <string>
 #include <utility>
 

diff --git a/google/cloud/storage/examples/storage_async_samples.cc b/google/cloud/storage/examples/storage_async_samples.cc
@@ -28,6 +28,7 @@
 #include <iostream>
 #include <map>
 #include <random>
+#include <sstream>
 #include <string>
 #include <utility>
 #include <vector>

diff --git a/google/cloud/storage/internal/access_control_common_parser.cc b/google/cloud/storage/internal/access_control_common_parser.cc
@@ -14,6 +14,7 @@
 
 #include "google/cloud/storage/internal/access_control_common_parser.h"
 #include "google/cloud/storage/internal/metadata_parser.h"
+#include <utility>
 // This file contains the implementation for deprecated functions, we need to
 // disable the warnings.
 #include "google/cloud/internal/disable_deprecation_warnings.inc"

diff --git a/google/cloud/storage/internal/bucket_acl_requests_test.cc b/google/cloud/storage/internal/bucket_acl_requests_test.cc
@@ -17,6 +17,7 @@
 #include "google/cloud/testing_util/status_matchers.h"
 #include <gmock/gmock.h>
 #include <nlohmann/json.hpp>
+#include <sstream>
 #include <string>
 
 namespace google {

diff --git a/google/cloud/storage/internal/bucket_requests_test.cc b/google/cloud/storage/internal/bucket_requests_test.cc
@@ -23,6 +23,7 @@
 #include "google/cloud/testing_util/status_matchers.h"
 #include <gmock/gmock.h>
 #include <nlohmann/json.hpp>
+#include <sstream>
 #include <string>
 #include <utility>
 #include <vector>

diff --git a/google/cloud/storage/internal/connection_factory.cc b/google/cloud/storage/internal/connection_factory.cc
@@ -19,6 +19,7 @@
 #include "google/cloud/storage/internal/tracing_connection.h"
 #include "google/cloud/internal/opentelemetry.h"
 #include <memory>
+#include <utility>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/internal/default_object_acl_requests_test.cc b/google/cloud/storage/internal/default_object_acl_requests_test.cc
@@ -18,6 +18,7 @@
 #include "google/cloud/testing_util/status_matchers.h"
 #include <gmock/gmock.h>
 #include <nlohmann/json.hpp>
+#include <sstream>
 #include <string>
 
 namespace google {

diff --git a/google/cloud/storage/internal/error_credentials.h b/google/cloud/storage/internal/error_credentials.h
@@ -17,6 +17,7 @@
 
 #include "google/cloud/storage/oauth2/credentials.h"
 #include "google/cloud/storage/version.h"
+#include <utility>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/internal/generic_stub.h b/google/cloud/storage/internal/generic_stub.h
@@ -38,6 +38,8 @@
 #include "google/cloud/status_or.h"
 #include "google/cloud/version.h"
 #include <memory>
+#include <string>
+#include <vector>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/internal/generic_stub_factory.cc b/google/cloud/storage/internal/generic_stub_factory.cc
@@ -18,6 +18,7 @@
 #include "google/cloud/storage/options.h"
 #include "google/cloud/internal/algorithm.h"
 #include <memory>
+#include <utility>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/internal/hash_validator.cc b/google/cloud/storage/internal/hash_validator.cc
@@ -17,6 +17,7 @@
 #include "google/cloud/storage/internal/object_requests.h"
 #include "google/cloud/storage/object_metadata.h"
 #include <memory>
+#include <string>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/internal/hash_validator_impl.cc b/google/cloud/storage/internal/hash_validator_impl.cc
@@ -14,6 +14,7 @@
 
 #include "google/cloud/storage/internal/hash_validator_impl.h"
 #include "google/cloud/storage/object_metadata.h"
+#include <utility>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/internal/hash_values.cc b/google/cloud/storage/internal/hash_values.cc
@@ -14,6 +14,7 @@
 
 #include "google/cloud/storage/internal/hash_values.h"
 #include "google/cloud/internal/absl_str_cat_quiet.h"
+#include <utility>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/internal/hmac_key_metadata_parser.cc b/google/cloud/storage/internal/hmac_key_metadata_parser.cc
@@ -14,6 +14,7 @@
 
 #include "google/cloud/storage/internal/hmac_key_metadata_parser.h"
 #include "google/cloud/storage/internal/metadata_parser.h"
+#include <utility>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/internal/hmac_key_requests_test.cc b/google/cloud/storage/internal/hmac_key_requests_test.cc
@@ -16,6 +16,7 @@
 #include "google/cloud/storage/internal/hmac_key_metadata_parser.h"
 #include "google/cloud/testing_util/status_matchers.h"
 #include <gmock/gmock.h>
+#include <sstream>
 #include <string>
 #include <utility>
 

diff --git a/google/cloud/storage/internal/http_response_test.cc b/google/cloud/storage/internal/http_response_test.cc
@@ -16,6 +16,7 @@
 #include "google/cloud/testing_util/status_matchers.h"
 #include <gmock/gmock.h>
 #include <nlohmann/json.hpp>
+#include <sstream>
 #include <string>
 
 namespace google {

diff --git a/google/cloud/storage/internal/impersonate_service_account_credentials.cc b/google/cloud/storage/internal/impersonate_service_account_credentials.cc
@@ -17,6 +17,8 @@
 #include "google/cloud/internal/unified_rest_credentials.h"
 #include <memory>
 #include <mutex>
+#include <string>
+#include <utility>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/internal/make_jwt_assertion.cc b/google/cloud/storage/internal/make_jwt_assertion.cc
@@ -15,6 +15,7 @@
 #include "google/cloud/storage/internal/make_jwt_assertion.h"
 #include "google/cloud/storage/internal/base64.h"
 #include "google/cloud/internal/sign_using_sha256.h"
+#include <utility>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/internal/notification_requests_test.cc b/google/cloud/storage/internal/notification_requests_test.cc
@@ -18,6 +18,7 @@
 #include "google/cloud/storage/notification_payload_format.h"
 #include "google/cloud/testing_util/status_matchers.h"
 #include <gmock/gmock.h>
+#include <sstream>
 #include <string>
 
 namespace google {

diff --git a/google/cloud/storage/internal/object_acl_requests_test.cc b/google/cloud/storage/internal/object_acl_requests_test.cc
@@ -16,6 +16,7 @@
 #include "google/cloud/storage/internal/object_access_control_parser.h"
 #include "google/cloud/testing_util/status_matchers.h"
 #include <gmock/gmock.h>
+#include <sstream>
 #include <string>
 
 namespace google {

diff --git a/google/cloud/storage/internal/object_requests_test.cc b/google/cloud/storage/internal/object_requests_test.cc
@@ -19,6 +19,7 @@
 #include "google/cloud/testing_util/status_matchers.h"
 #include <gmock/gmock.h>
 #include <nlohmann/json.hpp>
+#include <sstream>
 #include <string>
 #include <utility>
 #include <vector>

diff --git a/google/cloud/storage/internal/request_project_id.cc b/google/cloud/storage/internal/request_project_id.cc
@@ -14,6 +14,7 @@
 
 #include "google/cloud/storage/internal/request_project_id.h"
 #include "google/cloud/internal/make_status.h"
+#include <utility>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/internal/service_account_requests_test.cc b/google/cloud/storage/internal/service_account_requests_test.cc
@@ -14,6 +14,7 @@
 
 #include "google/cloud/storage/internal/service_account_requests.h"
 #include <gmock/gmock.h>
+#include <sstream>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/internal/sign_blob_requests_test.cc b/google/cloud/storage/internal/sign_blob_requests_test.cc
@@ -15,6 +15,7 @@
 #include "google/cloud/storage/internal/sign_blob_requests.h"
 #include "google/cloud/testing_util/status_matchers.h"
 #include <gmock/gmock.h>
+#include <sstream>
 #include <string>
 #include <utility>
 

diff --git a/google/cloud/storage/internal/signed_url_requests_test.cc b/google/cloud/storage/internal/signed_url_requests_test.cc
@@ -17,6 +17,7 @@
 #include "google/cloud/internal/parse_rfc3339.h"
 #include "google/cloud/testing_util/status_matchers.h"
 #include <gmock/gmock.h>
+#include <sstream>
 #include <string>
 #include <vector>
 

diff --git a/google/cloud/storage/internal/storage_connection.cc b/google/cloud/storage/internal/storage_connection.cc
@@ -13,6 +13,8 @@
 // limitations under the License.
 
 #include "google/cloud/storage/internal/storage_connection.h"
+#include <utility>
+#include <vector>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/internal/tracing_connection.cc b/google/cloud/storage/internal/tracing_connection.cc
@@ -16,6 +16,9 @@
 #include "google/cloud/storage/internal/tracing_object_read_source.h"
 #include "google/cloud/internal/opentelemetry.h"
 #include <memory>
+#include <string>
+#include <utility>
+#include <vector>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/internal/unified_rest_credentials.cc b/google/cloud/storage/internal/unified_rest_credentials.cc
@@ -25,6 +25,9 @@
 #include "google/cloud/internal/oauth2_google_credentials.h"
 #include "google/cloud/internal/oauth2_service_account_credentials.h"
 #include <memory>
+#include <string>
+#include <utility>
+#include <vector>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/oauth2/credentials.cc b/google/cloud/storage/oauth2/credentials.cc
@@ -14,6 +14,7 @@
 
 #include "google/cloud/storage/oauth2/credentials.h"
 #include "google/cloud/internal/make_status.h"
+#include <vector>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/oauth2/refreshing_credentials_wrapper.cc b/google/cloud/storage/oauth2/refreshing_credentials_wrapper.cc
@@ -17,6 +17,7 @@
 #include "google/cloud/internal/oauth2_refreshing_credentials_wrapper.h"
 #include "absl/strings/str_split.h"
 #include <memory>
+#include <string>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/testing/upload_hash_cases.cc b/google/cloud/storage/testing/upload_hash_cases.cc
@@ -13,6 +13,7 @@
 // limitations under the License.
 
 #include "google/cloud/storage/testing/upload_hash_cases.h"
+#include <vector>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/tests/bucket_integration_test.cc b/google/cloud/storage/tests/bucket_integration_test.cc
@@ -21,6 +21,7 @@
 #include "google/cloud/testing_util/status_matchers.h"
 #include <gmock/gmock.h>
 #include <chrono>
+#include <sstream>
 #include <string>
 #include <thread>
 #include <utility>

diff --git a/google/cloud/storage/tests/error_injection_integration_test.cc b/google/cloud/storage/tests/error_injection_integration_test.cc
@@ -20,6 +20,7 @@
 #include "google/cloud/testing_util/status_matchers.h"
 #include "absl/types/optional.h"
 #include <gmock/gmock.h>
+#include <sstream>
 #include <string>
 #include <vector>
 #ifndef _WIN32

diff --git a/google/cloud/storage/tests/grpc_integration_test.cc b/google/cloud/storage/tests/grpc_integration_test.cc
@@ -17,6 +17,7 @@
 #include "google/cloud/testing_util/setenv.h"
 #include "google/cloud/testing_util/status_matchers.h"
 #include <gmock/gmock.h>
+#include <sstream>
 #include <string>
 #include <utility>
 #include <vector>

diff --git a/google/cloud/storage/tests/object_file_integration_test.cc b/google/cloud/storage/tests/object_file_integration_test.cc
@@ -21,6 +21,7 @@
 #include <gmock/gmock.h>
 #include <cstdio>
 #include <fstream>
+#include <sstream>
 #include <string>
 #include <thread>
 #include <vector>

diff --git a/google/cloud/storage/tests/object_integration_test.cc b/google/cloud/storage/tests/object_integration_test.cc
@@ -25,6 +25,7 @@
 #include <cstring>
 #include <iostream>
 #include <memory>
+#include <sstream>
 #include <string>
 #include <utility>
 #include <vector>

diff --git a/google/cloud/storage/tests/object_read_large_integration_test.cc b/google/cloud/storage/tests/object_read_large_integration_test.cc
@@ -20,6 +20,7 @@
 #include <fstream>
 #include <iostream>
 #include <iterator>
+#include <sstream>
 #include <string>
 #include <utility>
 #include <vector>

diff --git a/google/cloud/storage/tests/object_read_stream_integration_test.cc b/google/cloud/storage/tests/object_read_stream_integration_test.cc
@@ -16,6 +16,9 @@
 #include "google/cloud/storage/testing/storage_integration_test.h"
 #include "google/cloud/internal/getenv.h"
 #include "google/cloud/testing_util/status_matchers.h"
+#include <gmock/gmock.h>
+#include <utility>
+#include <vector>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/tests/object_resumable_write_integration_test.cc b/google/cloud/storage/tests/object_resumable_write_integration_test.cc
@@ -18,6 +18,7 @@
 #include "google/cloud/testing_util/status_matchers.h"
 #include <gmock/gmock.h>
 #include <iostream>
+#include <sstream>
 #include <string>
 #include <thread>
 #include <utility>

diff --git a/google/cloud/storage/tests/object_write_stream_integration_test.cc b/google/cloud/storage/tests/object_write_stream_integration_test.cc
@@ -16,6 +16,7 @@
 #include "google/cloud/storage/testing/storage_integration_test.h"
 #include "google/cloud/internal/getenv.h"
 #include "google/cloud/testing_util/status_matchers.h"
+#include <utility>
 
 namespace google {
 namespace cloud {

diff --git a/google/cloud/storage/tests/object_write_streambuf_integration_test.cc b/google/cloud/storage/tests/object_write_streambuf_integration_test.cc
@@ -20,6 +20,7 @@
 #include "google/cloud/testing_util/status_matchers.h"
 #include <gmock/gmock.h>
 #include <memory>
+#include <sstream>
 #include <string>
 #include <utility>