Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress annoying warning #483

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mohamedhafez
Copy link

This solves #424 for now. The issue has been open for over a year, so I'm guessing nobody has the bandwidth to fix it. This will keep it from spamming log files in the meantime

This solves googleapis#424 for now. The issue has been open for over a year, so I'm guessing nobody has the bandwidth to fix it. This will keep it from spamming log files in the meantime
@mohamedhafez mohamedhafez requested a review from a team as a code owner May 25, 2024 01:59
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@dazuma
Copy link
Member

dazuma commented Jun 10, 2024

Unfortunately silence_warnings is a Rails-ism and not available in plain Ruby.

@danini-the-panini
Copy link

danini-the-panini commented Jan 10, 2025

module_function on an attr_accessor effectively just makes it private, so this should be fixed by moving the attr_accessor into a private section

EDIT:

Making it private might not be the intended outcome. If this is meant to also be accessible on the module, then perhaps it should be:

mattr_accessor :default_connection
attr_accessor :default_connection

module_function

def connection
#...

Otherwise I think the module_function should just be removed entirely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants