Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will greatly improve ergonomics for customers and our downstream libraries. Notably:
GoogleAuth
/AuthClient
can be a drop-in replacement for libraries requiringfetch
-API complianceHere's an example for customers wanting this functionality:
Impact
Customers can now streamline their request management to:
Testing
Added tests and updated some samples to use
#fetch
.Additional Information
To avoid parsing/marshaling the returned data from
GoogleAuth#fetch
/AuthClient#fetch
toGaxiosResponse#data
, set{responseType: 'stream'}
for theGaxiosOptions
.This can be useful when using this API as a drop-in replacement for
fetch
and the receiving API expectsResponse#bodyUsed
to befalse
.We could expose a
noMarshalFetchData
option here forAuthClientOptions
or upstream inGaxiosOptions
if this becomes a widely-desired feature.Builds on:
fetch
-Compatible API gaxios#680🦕