Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Asynchronous Features To Close Issue #1637 #2469

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ChynnaSyas
Copy link

@ChynnaSyas ChynnaSyas commented Aug 26, 2024

We have added asynchronous features for HTTP requests, authentication, as well as completed some of the checklist below:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<1637> 🦕

ChynnaSyas and others added 3 commits August 6, 2024 10:04
- Modified the authentication to integrate asynchronous functionality
- Modified the where HttpRequest is called to AsyncHttpRequest class

Co-authored-by: Kyongsu Kang
Co-authored-by: Lizzy Zhou
Co-Author-By: Kyongsu Kang
Co-Author-By: Lizzy Zhou
Co-Authored by: Kyongsu Kang
Co-Authored by: Lizzy Zhou
@ChynnaSyas ChynnaSyas requested a review from a team as a code owner August 26, 2024 00:43
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants