Skip to content

fix: Use version.py instead of pkg_resources on v1 #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kyohei3
Copy link

@kyohei3 kyohei3 commented Jan 24, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1670 🦕

@kyohei3 kyohei3 marked this pull request as ready for review January 24, 2022 22:48
@kyohei3 kyohei3 requested a review from a team as a code owner January 24, 2022 22:48
@kyohei3 kyohei3 changed the base branch from v1 to main January 24, 2022 23:25
@kyohei3 kyohei3 changed the base branch from main to v1 January 24, 2022 23:25
@kyohei3
Copy link
Author

kyohei3 commented Jan 24, 2022

Kokoro has been Expected — Waiting for status to be reported status for 10 hours...
Trying to refresh the status by changing base branch temporally, but I'm not sure if a new build was triggered successfully.

@kyohei3
Copy link
Author

kyohei3 commented Jan 25, 2022

hmm, kokoro was not triggered yet. will try to close and re-open this pr.

@kyohei3 kyohei3 closed this Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant