Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl: cmd/generate: add initial command interface #5

Merged
merged 1 commit into from
Nov 25, 2024
Merged

impl: cmd/generate: add initial command interface #5

merged 1 commit into from
Nov 25, 2024

Conversation

julieqiu
Copy link
Member

Add initial command interface for generator.

@julieqiu julieqiu requested a review from a team as a code owner November 25, 2024 17:30
jskeet
jskeet approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is different from what we just discussed (naturally) but if you want to merge it anyway and make a change from there, that's fine.

internal/generate/flags.go Outdated Show resolved Hide resolved
@julieqiu julieqiu force-pushed the julie-pr3 branch 4 times, most recently from 8daad25 to 2c0b25d Compare November 25, 2024 18:29
@julieqiu julieqiu requested a review from a team November 25, 2024 18:30
@julieqiu
impl: cmd/generate: add inital command interface
992d642 
Add initial command interface for generator.
@julieqiu julieqiu merged commit 909f79f into googleapis:main Nov 25, 2024
4 checks passed
@julieqiu julieqiu deleted the julie-pr3 branch November 25, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julieqiu @jskeet