Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): delete flaky test #1565

Merged
merged 4 commits into from
Jul 24, 2024
Merged

fix(tests): delete flaky test #1565

merged 4 commits into from
Jul 24, 2024

Conversation

punya
Copy link
Contributor

@punya punya commented Jul 23, 2024 •
edited
Loading

This test is already disabled for current and future versions of NodeJS,
and I don't think it's worth putting in the effort to fix flakiness when
the whole test will soon be a no-op.

Also fix other issues that were (deterministically) breaking the build:

  • Disable codecov: we were running out of API quota, and most other GCP repos had previously disabled it for unrelated reasons
  • Migrate eslint ignores from the "node" plugin to the "n" plugin

Fixes #1562, fixes #1525, fixes #1524, fixes #1523, fixes #1522, fixes #1500, fixes #1499, fixes #1498, fixes #1497, fixes #1496

@punya
fix(tests): delete flaky test
90669b4 
This test is already disabled for current and future versions of NodeJS,
and I don't think it's worth putting in the effort to fix flakiness when
the whole test will soon be a no-op.
@punya punya requested review from a team as code owners July 23, 2024 18:35
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. labels Jul 23, 2024
aabmass

This comment was marked as resolved.

Sign in to view

@generated-files-bot Generated Files Bot

This comment was marked as outdated.

Sign in to view
@punya
fix(test): disable codecov
8421850 
Codecov uploads are being throttled (429) because
we are exceeding monthly quota
@punya
fix: migrate eslint ignores
0e01a7d
@punya punya merged commit 78fde86 into main Jul 24, 2024
18 of 19 checks passed
@punya punya deleted the delete-flaky-test branch July 24, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabmass aabmass aabmass approved these changes

Assignees
No one assigned
Labels
api: cloudtrace Issues related to the googleapis/cloud-trace-nodejs API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test-plugins-no-project-num should not break without project num: mysql2-1 failed test-plugins-no-project-num should not break without project num: mysql-2 failed test-plugins-no-project-num should not break without project num: restify failed test-plugins-no-project-num should not break without project num: redis failed test-plugins-no-project-num should not break without project num: mongo failed
test-plugins-no-project-num should not break without project num Skipping anything over 20: redis failed test-plugins-no-project-num should not break without project num Skipping anything over 20: restify failed test-plugins-no-project-num should not break without project num Skipping anything over 20: mysql-2 failed test-plugins-no-project-num should not break without project num Skipping anything over 20: mysql2-1 failed test-plugins-no-project-num should not break without project num Skipping anything over 20: express failed
2 participants
@punya @aabmass