New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): always check if tempfile exists #1041

Merged

antongolub merged 2 commits into google:main from antongolub:fix-cli-tempfile

Dec 26, 2024

Collaborator

antongolub commented Dec 25, 2024 •

edited

Loading

What's wrong now:

Processing readme.md may override existing user's local readme.md.mjs
Markdown flow ignores --ext and applies .mjs everytime, so cjs contents fails.
Fetching from https ignores --ext option too: https://example.com/path/script.js.bak calls <temp>script.js.bak instead of <temp>script.js.mjs

Tests pass
Appropriate changes to README are included in PR


          fix(cli): always check if tempfile exist

52df4dd

antongolub requested a review from antonmedv

December 25, 2024 22:37

antongolub changed the title ~~fix(cli): always check if tempfile exist~~ fix(cli): always check if tempfile exists


          chore: linting

259397b

antongolub merged commit 6ecbad2 into google:main

19 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet