Rename AsBytes to IntoBytes
#700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
as-bytes-rename-to-to-bytes
branch
3 times, most recently
from
b895345 to
6ccd880
Compare
joshlf
force-pushed
the
as-bytes-rename-to-to-bytes
branch
from
6ccd880 to
98330a0
Compare
joshlf
force-pushed
the
as-bytes-rename-to-to-bytes
branch
from
98330a0 to
37f544f
Compare
joshlf
force-pushed
the
as-bytes-rename-to-to-bytes
branch
from
37f544f to
0586963
Compare
Previously, `T: AsBytes` indicated that `&T -> &[u8]` was a valid transformation. As of #682, `T: AsBytes` only indicates that `T -> [u8]` is a valid transformation. This slightly changes the meaning of `AsBytes` and makes `IntoBytes` a more appropriate name since it only permits value rather than reference transmutations. This also brings the pair of `FromBytes` and `IntoBytes` in line with the standard library `From` and `Into` traits from a naming perspective. Closes #695
joshlf
force-pushed
the
as-bytes-rename-to-to-bytes
branch
from
0586963 to
d6e93da
Compare
jswrenn
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
T: AsBytesindicated that&T -> &[u8]was a validtransformation. As of #682,
T: AsBytesonly indicates thatT -> [u8]is a valid transformation. This slightly changes the meaning of
AsBytesand makesIntoBytesa more appropriate name since it onlypermits value rather than reference transmutations. This also brings the
pair of
FromBytesandIntoBytesin line with the standard libraryFromandIntotraits from a naming perspective.Closes #695