Strengthen soundness proof for size_of_val_raw #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswrenn
reviewed
Aug 6, 2024
src/macro_util.rs
Outdated
Comment on lines
152
to
154
| // [1] TODO(#429), | ||
| // TODO(https://github.com/rust-lang/unsafe-code-guidelines/issues/465#issuecomment-1782206516): | ||
| // Citation for this? |
There was a problem hiding this comment.
Is [1] still referenced somewhere after your revision?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1574 +/- ##
=======================================
Coverage 87.70% 87.70%
=======================================
Files 15 15
Lines 5563 5563
=======================================
Hits 4879 4879
Misses 684 684 ☔ View full report in Codecov by Sentry. |
Previously, we needed to rely on the fact that the instance of any valid Rust type with 0 elements has a size (in number of bytes) which is not greater than `isize::MAX`. Providing this as a guarantee turned out to be controversial. [1] This was made possible by rust-lang/rust#126152. [1] rust-lang/unsafe-code-guidelines#465 (comment)
joshlf
force-pushed
the
size-of-val-raw-zero-dst
branch
from
04047d8 to
987c34a
Compare
jswrenn
approved these changes
Aug 6, 2024
|
Can we just use |
A few issues:
Note that |
djkoloski
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we needed to rely on the fact that the instance of any valid Rust type with 0 elements has a size (in number of bytes) which is not greater than
isize::MAX. Providing this as a guarantee turned out to be controversial. [1]This was made possible by rust-lang/rust#126152.
[1] rust-lang/unsafe-code-guidelines#465 (comment)