Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#[allow(where_clauses_object_safety)] in src/lib.rs #151

Closed
wants to merge 1 commit into from

Conversation

andrewpollack
Copy link

Issue: #150

Resolution for allow until lint is either turned error, or lint is resolved

@joshlf
Copy link
Member

joshlf commented Dec 31, 2022

Thanks for this, @andrewpollack! It looks good; is there a reason you closed it?

@andrewpollack
Copy link
Author

@joshlf introducing the allow wasn't successfully resolving the warning. The allow seemingly needs to be placed where the trait object is created, even though the lint is firing on the trait definition (i.e. where the crate is being used, as opposed to the source itself). I closed the PR since I wasn't successful in repressing the warning

rust-lang/rust#102546 captures this as well

@andrewpollack
Copy link
Author

That said, if there's another way I can approach to resolve this, I'd be happy to do so! For the time being, we're holding off on changes in our codebase firing from this lint until upstream discussions settle down (see comment threads on rust-lang/rust#106247 )

@joshlf
Copy link
Member

joshlf commented Dec 31, 2022

Ah got it, thanks for the clarification! I likely won't have time to work on this for the next few weeks, but I've marked your issue as a release blocker for 0.7.0, so it'll get resolved before that release.

@andrewpollack
Copy link
Author

Awesome, thank you @joshlf!

@joshlf
Copy link
Member

joshlf commented Dec 31, 2022

np!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants