Rename XSECURELOCK_SAVER_STOP_ON_DPMS #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct name should be XSECURELOCK_SAVER_STOP_ON_BLANK. We also starts children when screensaver is on, but screen is not blanked, or when screensaver is one and screen is blanked, but this option is not enabled.
|
@divVerent any updates, do you want to pull this in? I'm asking as I'd also like to request if a new release can be issued which contains this feature? It has been a rather long time now. |
|
Oh sorry, I missed this. Yes, this change is uncontroversial, getting it in. |
|
Thank you! |
tzeikob
added a commit
to tzeikob/xsecurelock
that referenced
this pull request
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct name should be XSECURELOCK_SAVER_STOP_ON_BLANK. We also starts children when screensaver is on, but screen is not blanked, or when screensaver is one and screen is blanked, but this option is not enabled.
I can do a separate pull request for this one-line change if you prefer. Then, I get the same behaviour than #139 by setting
XSECURELOCK_BLANK_TIMEOUT=-1.