Skip to content

Simplify pop_cnt() #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 5, 2025
Merged

Simplify pop_cnt() #770

merged 4 commits into from
Mar 5, 2025

Conversation

zhouwfang
Copy link
Contributor

@zhouwfang zhouwfang commented Mar 5, 2025

The previous implementation was unnecessarily complicated. I hope it is convincing now.

#46

@zhouwfang zhouwfang requested a review from ia0 as a code owner March 5, 2025 03:00
Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is simplifying, but that still feels wrong. I'll have to take a look when I get time.

@ia0
Copy link
Member

ia0 commented Mar 5, 2025

Waiting for #771 before updating and merging.

@ia0 ia0 merged commit a424c6b into google:dev/fast-interp Mar 5, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants