Skip to content

Combine Label values in Frame #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Sep 6, 2024
Merged

Combine Label values in Frame #598

merged 18 commits into from
Sep 6, 2024

Conversation

zhouwfang
Copy link
Contributor

@zhouwfang zhouwfang commented Sep 2, 2024 •
edited
Loading

This is the first step towards adding a value stack in Thread. The next step is to merge locals and labels_values in Frame. After that, we can create a value stack in Thread by combining the values from the Frame's.

#46

@zhouwfang zhouwfang requested a review from ia0 as a code owner September 2, 2024 22:56
@zhouwfang zhouwfang changed the title Move Label::values to Frame Add Label values in Frame Sep 2, 2024
@zhouwfang zhouwfang changed the title Add Label values in Frame Combine Label values in Frame Sep 2, 2024
ia0
ia0 reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think the overall plan looks good.

zhouwfang
zhouwfang commented Sep 4, 2024
View reviewed changes
@zhouwfang
fix: some computation errors
4c2ebc9 
failures:
    br
    br_if
    br_table
    if_
    labels
    loop_
    switch
    unreachable
    unwind

test result: FAILED. 79 passed; 9 failed; 2 ignored; 0 measured; 0 filtered out; finished in 5.16s
zhouwfang
zhouwfang commented Sep 5, 2024
View reviewed changes
ia0
ia0 reviewed Sep 5, 2024
View reviewed changes
@zhouwfang zhouwfang requested a review from ia0 September 6, 2024 06:55
ia0
ia0 reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@ia0 ia0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be pushing the changes. It's faster than iterate. Feel free to try to rediscover them on your own.

@ia0 ia0 merged commit 1b79dae into google:dev/fast-interp Sep 6, 2024
20 checks passed
@zhouwfang zhouwfang mentioned this pull request Sep 7, 2024
Merged
ia0 added a commit that referenced this pull request Sep 11, 2024
@zhouwfang @ia0
Merge locals and label values in Frame (#605)
bea2ebf 
Continuation of #598 towards adding a value stack in `Thread`.

#46

---------

Co-authored-by: Zhou Fang <[email protected]>
Co-authored-by: Julien Cretin <[email protected]>
Co-authored-by: Julien Cretin <[email protected]>
@ia0 ia0 linked an issue Sep 19, 2024 that may be closed by this pull request
Interpreter performance and footprint #46
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia0 ia0 ia0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interpreter performance and footprint
2 participants
@zhouwfang @ia0