Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails due to outdated armadillo version and checksum in WORKSPACE #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aadilghani1
Copy link

No description provided.

Copy link

google-cla bot commented Sep 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Arno-Riverside
Copy link

Why has this PR not been merged ? It's straightforward and 6 months later the build still breaks because http://sourceforge.net/projects/arma/files/armadillo-9.900.1.tar.xz in WORKSPACE does not exist.

@aadilghani1
Copy link
Author

Why has this PR not been merged ? It's straightforward and 6 months later the build still breaks because http://sourceforge.net/projects/arma/files/armadillo-9.900.1.tar.xz in WORKSPACE does not exist.

Exactly my thought, would like a review ASAP

@malto101
Copy link

malto101 commented Feb 4, 2025

Maybe if we tag them, they can see it?

@Arno-Riverside
Copy link

@mchinen @aluebs @FeargusOG You guys are the main contributors so I'm tagging you here :)

@conradsnicta
Copy link

conradsnicta commented Feb 19, 2025

Why has this PR not been merged ?

@Arno-Riverside @aadilghani1 visqol is now clearly abandonware, on par with many other things created by Google.

Suggest you fork it and declare the fork as the new maintained version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants