Skip to content

Commit

Permalink
PR #19649: [ROCm] Implement hermetic rocm dependency
Browse files Browse the repository at this point in the history
Imported from GitHub PR openxla/xla#19649

This change has as a goal to introduce an external dependency to the rocm library and tools.

Building xla with the hermetic rocm is done by using these env variables:

--repo_env=OS=ubuntu_20.04
--repo_env=ROCM_VERSION=6.2.0

To use only hermetic libs define this flag:
--@local_config_rocm//rocm:use_rocm_hermetic_rpath=True
This flag will make rpaths and configs to look inside the sandbox
If flag is not set then default installation paths are used e.g /opt/rocm

One has to provie OS version and ROCm version to initialize a proper rocm repository.
If these flags are not set then default ROCm installation will be used to build XLA.

depends-on: openxla/xla#19691

Copybara import of the project:

--
cf744eca78f697144e122c6a9d1aa8fc52722b20 by Alexandros Theodoridis <[email protected]>:

Implement hermetic rocm dependency

--
4f4ad859ec3143fdb04f7792541c61b98c708397 by Alexandros Theodoridis <[email protected]>:

Add missing dependency

--
8e164f765b45b5e5d118b02695fd6d6e2b0b232d by Alexandros Theodoridis <[email protected]>:

Add missing dependency and remove so files from data

--
35538f4922b5b28b9debd0ce17bb15b83b5921fc by Alexandros Theodoridis <[email protected]>:

Rename setting to use_rocm_hermetic_rpath

--
58d140220e9e58572c9a7ae3de2ec1ea189566d3 by Alexandros Theodoridis <[email protected]>:

Fix build for cuda and cpu

Merging this change closes #19649

PiperOrigin-RevId: 713248195
  • Loading branch information
alekstheod authored and copybara-github committed Jan 8, 2025
1 parent 40ee94f commit e2bd181
Show file tree
Hide file tree
Showing 10 changed files with 1,033 additions and 191 deletions.
6 changes: 3 additions & 3 deletions third_party/gpus/crosstool/BUILD.rocm.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ filegroup(
)

filegroup(
name = "crosstool_wrapper_driver_is_not_gcc",
srcs = ["clang/bin/crosstool_wrapper_driver_is_not_gcc"],
name = "crosstool_wrapper_driver_is_not_gcc",
srcs = [":clang/bin/crosstool_wrapper_driver_is_not_gcc"],
data = ["@local_config_rocm//rocm:all_files"],
)

Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ def InvokeHipcc(argv, log=False):
hipccopts += defines
hipccopts += std_options
hipccopts += m_options
hipccopts += ' --rocm-path="%{rocm_path}" '

if depfiles:
# Generate the dependency file
Expand Down
Loading

0 comments on commit e2bd181

Please sign in to comment.