Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test to ensure invalid timestamp conversions do not occur #2954

Merged
merged 9 commits into from
Oct 25, 2023

Conversation

bwhelan212
Copy link
Contributor

  • What new feature is being introduced with this PR?
    Created a unit test function that takes data from validate_timestamp_conversion.csv and prevents invalid timestamp conversion by someone editing the codebase.

Checks

  • All tests succeed.
  • Unit tests added.
  • e2e tests added.
  • Documentation updated.

Co-authors: @hankngo @Isaac-G5900

@google-cla
Copy link

google-cla bot commented Oct 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@berggren berggren self-requested a review October 25, 2023 09:47
@berggren berggren added this to the Release: 20231025 milestone Oct 25, 2023
@berggren berggren changed the title Wrote preventative unit test to ensure future invalid timestamp conversions do not occur Unit test to ensure invalid timestamp conversions do not occur Oct 25, 2023
@berggren
Copy link
Contributor

Thanks for contributing!

@berggren berggren merged commit 30da8aa into google:master Oct 25, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants