Instantiate side panel only once #2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jkppr PTAL |
jkppr
approved these changes
Oct 24, 2023
Comment on lines
+66
to
+68
| <v-btn icon @click="toggleLeftPanel"> | ||
| <v-icon>mdi-menu</v-icon> | ||
| </v-btn> |
There was a problem hiding this comment.
UX nit: on an empty sketch this icon still exists but will not toggle anything since there is no left panel yet. I would recommend to hide this on a sketch without any timeline.
There was a problem hiding this comment.
Good idea. and Ack, will do that in a followup PR as this is related to some other aspects of the left side panel.
jkppr
reviewed
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes unnecessary data fetches on expand/collapse of the side panel.
Closing issues
closes #2948