Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting regular expressions for features extraction #2932

Merged
merged 11 commits into from
Oct 10, 2023
Merged

Adjusting regular expressions for features extraction #2932

merged 11 commits into from
Oct 10, 2023

Conversation

tomchop
Copy link
Collaborator

@tomchop tomchop commented Oct 10, 2023

Some changes to the regexes in features.yaml, mostly relaxing them:

  • Removed the header check for sshd/pid, given that there were two versions: \[sshd, pid: \d+\] and \[sshd\] \[\d+\]
  • Removed the .* at the start of some regexes which must've made them much slower.

@tomchop tomchop requested a review from jkppr October 10, 2023 10:12
@tomchop tomchop marked this pull request as draft October 10, 2023 10:13
@jkppr jkppr marked this pull request as ready for review October 10, 2023 10:38
@jkppr jkppr self-assigned this Oct 10, 2023
Copy link
Collaborator

@jkppr jkppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please decouple the changes to the features.yaml from the changes to the yeti analyzer?
Have this PR just focused on the features changes and add the changes for the analyzer in your #2930 PR

@tomchop
Copy link
Collaborator Author

tomchop commented Oct 10, 2023

I sent it too soon because I'm working out of the same branch, but it should get decoupled as soon as the other one is merged. :)

@berggren berggren changed the title Features Adjusting regular expressions for features extraction Oct 10, 2023
@jkppr jkppr merged commit 15a7991 into google:master Oct 10, 2023
24 checks passed
@tomchop tomchop deleted the features branch October 10, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants