This repository has been archived by the owner on Aug 18, 2023. It is now read-only.
Automate inference and make models arguments to inference engines #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* try updating * update python versions * Tests passing * increase tolerance for flaky test * update setup.py
farice
previously approved these changes
Feb 15, 2022
Closed
farice
reviewed
Feb 15, 2022
farice
previously approved these changes
Feb 15, 2022
Closed
farice
approved these changes
Feb 15, 2022
|
I hope you don't mind me merging - just want to fork your QMHL PR with this one merged. We can revert if there was something else you wanted to add here |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors inference classes to clean up interfaces.
Resolves #115. Also, makes
energy(circuit) a constructor argument ofEnergyInference(QuantumInference). Models not being connected to their inference engines was making some interfaces more cluttered than they needed to be.Depends on #175