Google sync #1593
Merged
Google sync #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiperOrigin-RevId: 609075254
Fixes a bug that affects typeshed's pytype_test. See python/typeshed#11333 for context. I wasn't able to write a test for this because it's triggered by some complicated combination of mutually dependent pyi files and mutually recursive aliases. PiperOrigin-RevId: 609414132
Some users seem to like creating classes that are both dataclasses for inheritance and protocols for structural typing, so we need __match_args__ to be present for protocol matching to work properly. PiperOrigin-RevId: 610507303
PiperOrigin-RevId: 610515095
PiperOrigin-RevId: 610588363
My previous attempt to always set __match_args__ didn't work because the type varies depending on the number of dataclass fields, so subclassing messes up protocol matching. Instead, we can set PyTDClass.match_args from the dataclass metadata and not set __match_args__ at all. PiperOrigin-RevId: 610650564
PiperOrigin-RevId: 610786166
rchen152
force-pushed
the
google_sync
branch
from
dca05ad to
be4def9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.