Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google sync #1550

Merged
merged 7 commits into from
Dec 14, 2023
Merged

Google sync #1550

merged 7 commits into from
Dec 14, 2023

Conversation

rchen152
Copy link
Contributor

No description provided.

Solumin and others added 7 commits December 14, 2023 09:29
… they're only imported.

e.g. for a file that only contains:
```py
from collections import OrderedDict
```

Pytype will completely drop `OrderedDict`, because that class is aliased to `typing.OrderedDict`.

PiperOrigin-RevId: 589215092
For a pyi file like:
```py
from typing import Any
dep: Any
x: dep.Thing
```
When processing local names, turn `x = pytd.Constant(NamedType("dep.Thing"))` into `x = pytd.Constant(NamedType("dep"))`. This makes it resolve later to `Any`.
PiperOrigin-RevId: 589298720
I'm still not sure why this happens. Blame jax.

PiperOrigin-RevId: 590393345
PiperOrigin-RevId: 590982684
@rchen152 rchen152 merged commit c9573ba into main Dec 14, 2023
21 checks passed
@rchen152 rchen152 deleted the google_sync branch December 14, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants