Google sync #1516
Merged
Google sync #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is causing a crash that's proving very hard to debug. PiperOrigin-RevId: 572376335
Adds tests to capture the state of our current partial support. PiperOrigin-RevId: 572392523
PiperOrigin-RevId: 572409804
PiperOrigin-RevId: 572417428
PiperOrigin-RevId: 572427153
This is needed to support the etils library (specifically: https://github.com/google/etils/blob/ea1f4876517656ef86deedaa41de47c87f00a999/etils/epy/py_utils.py#L33) in 3.11. PiperOrigin-RevId: 572613882
`parse_pyi.py` currently raises an exception when trying to decompose the results of `parser.parse_pyi`. It only returns a single value, but the left-hand side of the assignment specifies two variables. Since the second variable is unused, all this CL does is remove that portion of the assignment statement. #tftypes PiperOrigin-RevId: 572626607
The way this is supposed to work in 3.11 is that SEND gets a value from the generator, YIELD_VALUE yields it, and JUMP_BACKWARDS_NO_INTERRUPT jumps back to the SEND, repeatedly, until there are no more values to yield. At that point, SEND pushes the generator's return value onto the stack and jumps past the backwards jump. However, we removed the jump opcode, so we can't follow this implementation. Reusing 3.10's YIELD_FROM implementation seems to work. I also renamed some of the variables in our generator-related VM code to make it easier to follow. PiperOrigin-RevId: 572628644
`pytd_visitors.RenameModuleVisitor` previously skipped renaming a module if, when matching against the text of a node, it detected a `.` character in any text trailing the previous module name. This prevents the visitor from correctly removing module names added during pytype's serialization of ASTs. This change removes that check and only that check. The remaining check (which verifies that there is no text preceding the match) should be sufficient to prevent erroneous replacement in partial-match situations. #tftypes PiperOrigin-RevId: 572677520
After staring at this long enough, I think I figured out how to implement SEND properly. This (hopefully) has no user-visible effect. PiperOrigin-RevId: 572691337
PiperOrigin-RevId: 573074456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.