Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #229, #293: Modify parser.py to re-insert quotes correctly #307

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

stephenvincent27
Copy link

Passes:
parser_test.py
parser_fuzz_test.py (?)
main_test.py

We are not Python programmers primarily, so do let us know if there are fragments of code that can be rewritten in Python to make it more readable. Other than that, this code conforms faithfully to the flowchart we sent over earlier.

@google-cla
Copy link

google-cla bot commented Jan 13, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Author has not signed CLA label Jan 13, 2021
@stephenvincent27
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes Author has signed CLA and removed cla: no Author has not signed CLA labels Jan 13, 2021
@dbieber
Copy link
Member

dbieber commented Jan 26, 2021

Thank you for the PR!
I will let you know once I have looked through it more closely.

You mentioned in our discussion on #229 that you had some test cases. Could you add those to this PR?

@stephenvincent27
Copy link
Author

Hello @dbieber! Really sorry for the super-long hiatus. I've added relevant tests (some of which we'd discussed earlier), feel free to suggest additions/modifications to them.

@dbieber
Copy link
Member

dbieber commented Sep 24, 2021

Hello again. Thanks for adding the tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Author has signed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants