Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Physical Web Chrome App #290

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

louaybassbouss
Copy link
Contributor

This PR contains the initial version on the Physical Web Chrome App. It supports currently only SSDP protocol. Please refer to chrome/README.md and SSDP PR for more details.

@scottjenson
Copy link
Contributor

This client is ONLY SSDP so we're reluctant to check it in as it will cause confusion. If it were to also support BLE, we'd accept it.

@mmocny
Copy link
Contributor

mmocny commented Mar 9, 2016

Scott: How do we feel about just linking to user contributions like this, instead of merging them into this repo?

If we merge them into our repo, we should probably also support them, without understanding exactly how they are implemented.

I think we could create a page which links out to contributor apps like Louay's, and be clear that they aren't vetted. Then we needn't worry as much about limitations.

@scottjenson
Copy link
Contributor

I would agree. I'd be happy to link to this.

@louaybassbouss
Copy link
Contributor Author

Thx @scottjenson @mmocny for your comments. Yes I can put it somewhere on our git and you can link to it. but let me first check if I can add mdns using the chrome.mdns API.
Regarding BLE, we need to wait until the required BLE chrome APIs for beacon scan are available.

PS: I see this app is more for experimentation purposes. For best user experience, it makes more sense to implement it as en extension that shows a (physical-web) icon as Browser Action, but the required chrome APIs (UDP, mdns, BLE) are not available for extensions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants