Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move experimental flags into their own struct #463

Merged
merged 1 commit into from
Aug 2, 2023
Merged

refactor: move experimental flags into their own struct #463

merged 1 commit into from
Aug 2, 2023

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Aug 2, 2023

This pulls across the experimental struct from #183 which I'm assuming folks are happy with given that PR is approved - I think it is good to land this in its own PR as its technically an allowed breaking change (or "experimental change" if you will), and that way it can be explicitly linked to in changelogs etc without having to understand #183 as much.

Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@another-rex another-rex merged commit e6eccc2 into google:main Aug 2, 2023
@G-Rath G-Rath deleted the restructure-experimental-flags branch August 2, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants