ci: upgrade golangci-lint to v1.64
#1623
Closed
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuixq
approved these changes
Feb 13, 2025
|
Updating the linter fails because of the outdated snapshots, and updating the snapshots fails because of the linter. 🤦 |
|
@G-Rath can you patch the snapshot updates in this PR so that they can get merged together? |
cuixq
added a commit
that referenced
this pull request
Feb 14, 2025
At least this time it's a different snapshot 🤷 Patch #1623 so that workflows all pass --------- Co-authored-by: Xueqin Cui <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1623 +/- ##
==========================================
+ Coverage 68.98% 69.14% +0.15%
==========================================
Files 200 200
Lines 19069 19069
==========================================
+ Hits 13155 13185 +30
+ Misses 5203 5177 -26
+ Partials 711 707 -4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason our linting job has started failing without any actual error message to indicate the issue - I suspect it could be related to being on Go v1.23.6, but ultimately it seems upgrading to v1.64 of the linter resolves the issue.
As this introduces two new linters that want us to take actions, I've disabled them for now so that this can be landed as-is, but I've already got the patches for addressing their violations ready to go as dedicated PRs (of which #1620 is one)