-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: HTML report tinkering #1561
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1561 +/- ##
==========================================
- Coverage 69.31% 69.29% -0.02%
==========================================
Files 200 200
Lines 19038 19046 +8
==========================================
+ Hits 13196 13198 +2
- Misses 5135 5140 +5
- Partials 707 708 +1 ☔ View full report in Codecov by Sentry. |
Thanks! can you host one sample HTML on Github |
Hosted an example here: https://another-rex.github.io/TestPages/Vulnerability%20Scan%20Report.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up the JS file with best practice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Made a series of changes to resolve the issues identified in #1528
Hosted an example here: https://another-rex.github.io/TestPages/Vulnerability%20Scan%20Report.html
To make it easier to see the changes, when reviewing, use this link:
https://github.com/google/osv-scanner/pull/1561/files/bd8d5211e77612b1a0a68a4b00db1d40535fe400..8223593ef84cda34da84a57aecd12d3258ea1463
which select the diffs Excluding the first commit (use shift to select multiple commits). That moves the files around which breaks all of git's diffing. No change other than moving the files and reindenting is done in that first commit.
HTML:
CSS:
JS:
classList.toggle()
function)