feat: Update docker container scanning flag #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #1350 +/- ##
==========================================
+ Coverage 68.43% 68.73% +0.30%
==========================================
Files 187 187
Lines 17872 17884 +12
==========================================
+ Hits 12230 12293 +63
+ Misses 4968 4915 -53
- Partials 674 676 +2 ☔ View full report in Codecov by Sentry. |
oliverchang
approved these changes
Oct 30, 2024
|
|
||
| err = cmd.Start() | ||
| r.Infof("Pulling docker image (%q)...\n", dockerImageName) | ||
| err = runCommandLogError(r, "docker", "pull", "-q", dockerImageName) |
There was a problem hiding this comment.
What's the CLI output if docker doesn't exist on the user's system?
There was a problem hiding this comment.
Failed to run docker command ("docker pull -q alpine:non-existent-tag"): exec: "docker": executable file not found in $PATH
exec: "docker": executable file not found in $PATH
There was a problem hiding this comment.
nice! that's pretty clear to the user.
hogo6002
approved these changes
Oct 30, 2024
another-rex
added a commit
to another-rex/osv-scanner
that referenced
this pull request
Nov 1, 2024
Resolves google#1316 Update the --docker flag to: - Only accept one image to scan at a time (to make displaying results easier) - Call new image scanning function internally. - Acts like a convenience function for ``` docker save <image-name> > img-name.tar && osv-scanner --experimental-oci-image=img.name.tar ``` TODO: - [x] Add an ACCEPTANCE test which uses docker to pull down a stable image. - [x] Include a docker pull first, as docker save only saves images already on device and does not pull images online.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1316
Update the --docker flag to:
TODO: