Skip to content

ffmpeg: Clone repository to depth 1. #13293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025

Conversation

Ramneet-Singh
Copy link
Contributor

The full ffmpeg repository was being cloned while building the Docker image, resulting in large build times. This commit clones the repository upto a depth of 1.

The full ffmpeg repository was being cloned while building the Docker image, resulting in large build times. This commit clones the repository upto a depth of 1.
Copy link

github-actions bot commented May 8, 2025

Ramneet-Singh is a new contributor to projects/ffmpeg. The PR must be approved by known contributors before it can be merged. The past contributors are: kasper93, jzern, michaelni, h4ck0lympus, maflcko, JordyZomer, inferno-chromium

@Ramneet-Singh
Copy link
Contributor Author

Requesting review @kasper93 @jzern.

@jzern
Copy link
Contributor

jzern commented May 9, 2025

cc: @michaelni

This looks like it should work. Note I'm not an owner here, so someone on the oss-fuzz team will need to approve. The build failures look to be unrelated to the change and are in a dependency (freetype).

@kasper93
Copy link
Contributor

kasper93 commented May 9, 2025

This clone depth change is cosmetic. Repo is not that big for this to matter, but of course it is fine.

As for build failure it is likely fallout after Meson 1.8.0 release as we have seen in multiple projects already, mpv build is also broken because of that. I was kinda hoping for quick hotfix release, but maybe we should pin older Meson version at this point.

EDIT: #13297 (still doesn't work, will take a look later)

@michaelni
Copy link
Contributor

theres some LLM scrapers recently attacking git so a full clone can take 8minutes, depth 1 takes 3 minutes, and github does a full clone in about 1 minute. This should be fixed on our side by using anubis or some other anti DDOS meassures. But of course depth 1 or using https://github.com/FFmpeg/FFmpeg.git can be used if it helps

@DavidKorczynski DavidKorczynski merged commit 09053ac into google:master May 13, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants