Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluator: fix build script lookup #659

Merged
merged 1 commit into from
Oct 1, 2024
Merged

evaluator: fix build script lookup #659

merged 1 commit into from
Oct 1, 2024

Conversation

DavidKorczynski
Copy link
Collaborator

No description provided.

Signed-off-by: David Korczynski <[email protected]>
@DavidKorczynski
Copy link
Collaborator Author

Following the change here https://github.com/google/oss-fuzz-gen/pull/623/files#diff-cc74274207721385b333564f0db8639bd5acf97ee8830228c2b7eccec65e23c1R238 when the existing call to create_ossfuzz_project

self.create_ossfuzz_project(generated_oss_fuzz_project, target_path)
calls the function, then a FileNotFoundError will be thrown here:
if os.path.getsize(build_script_path) == 0:

This fixes it

@DavidKorczynski
Copy link
Collaborator Author

/gcbrun exp -n d-cov-152 -b minor-for-ci -ns 2 -rdn

@DavidKorczynski
Copy link
Collaborator Author

/gcbrun exp -n d-cov-153 -b minor-for-ci -ns 2 -rd

@DavidKorczynski
Copy link
Collaborator Author

Copy link
Collaborator

@arthurscchan arthurscchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: if build_script_path not exist, this line could still throw an error.

@arthurscchan arthurscchan merged commit e932c7f into main Oct 1, 2024
6 checks passed
@arthurscchan arthurscchan deleted the fix-eval-10 branch October 1, 2024 16:59
@DavidKorczynski
Copy link
Collaborator Author

Remark: if build_script_path not exist, this line could still throw an error.

Yeah, I assume we want a hard exit in this case, so it's intentional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants