Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save benchmarks in results and use for aggregate coverage calculation #650

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

DavidKorczynski
Copy link
Collaborator

@DavidKorczynski DavidKorczynski commented Sep 25, 2024

This fixes the discrepancy mentioned here #645 (comment). Saving the benchmark for each result has additional benefits than supporting the aggregate. It makes it easier to save results when auto-generation of benchmarks are used as part of the experiment (I use this a lot).

Notice not the full benchmark .yaml from benchmarks-set/... is set, but only the actual (one function or one test file) is saved per result dir.

Saving the benchmark for each result has additional benefits than
supporting the aggregate. It makes it easier to save results when
auto-generation of benchmarks are used as part of the experiment (I use
this a lot).

Signed-off-by: David Korczynski <[email protected]>
@DavidKorczynski
Copy link
Collaborator Author

/gcbrun exp -n d-cov-44 -b comparison -ns 4 -rd

Signed-off-by: David Korczynski <[email protected]>
@DavidKorczynski
Copy link
Collaborator Author

/gcbrun exp -n d-cov-45 -b comparison -ns 4 -rd

Signed-off-by: David Korczynski <[email protected]>
@DavidKorczynski
Copy link
Collaborator Author

Experiment is looking good, although there are some minor discrepancies still, but will look at those further down the line: https://llm-exp.oss-fuzz.com/Result-reports/ofg-pr/2024-09-26-650-d-cov-45-comparison/index.html

@AdamKorcz AdamKorcz merged commit b6fd6c1 into main Sep 25, 2024
6 checks passed
@AdamKorcz AdamKorcz deleted the save-benchmarks branch September 25, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants