-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
builder-runner: store textcov in workdir #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
/gcbrun exp -n d-cov-20 -b minor-for-ci -ns 2 |
/gcbrun exp -n d-cov-21 -b minor-for-ci -ns 2 |
Signed-off-by: David Korczynski <[email protected]>
/gcbrun skip |
Signed-off-by: David Korczynski <[email protected]>
AdamKorcz
approved these changes
Sep 21, 2024
Could you please notify me of these changes? |
+1 Please add us on PRs that modify core functionality such as these :) This is just in case we have anything else WIP that clashes. |
DavidKorczynski
added a commit
that referenced
this pull request
Sep 25, 2024
Introduced following the addition of textcov to the workdir in #638 This caused reports to individual benchmarks run to have wrong links, e.g. https://llm-exp.oss-fuzz.com/Result-reports/ofg-pr/2024-09-21-638-d-cov-21-minor-for-ci/benchmark/output-htslib-bcf_index_build/index.html Signed-off-by: David Korczynski <[email protected]>
DavidKorczynski
added a commit
that referenced
this pull request
Sep 25, 2024
Introduced following the addition of textcov to the workdir in #638 This caused reports to individual benchmarks run to have wrong links, e.g. https://llm-exp.oss-fuzz.com/Result-reports/ofg-pr/2024-09-21-638-d-cov-21-minor-for-ci/benchmark/output-htslib-bcf_index_build/index.html --------- Signed-off-by: David Korczynski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful to easily process textcov improvements for a benchmark, without doing it in sync with the experiments running