Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder-runner: store textcov in workdir #638

Merged
merged 5 commits into from
Sep 21, 2024
Merged

builder-runner: store textcov in workdir #638

merged 5 commits into from
Sep 21, 2024

Conversation

DavidKorczynski
Copy link
Collaborator

This is useful to easily process textcov improvements for a benchmark, without doing it in sync with the experiments running

Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
@DavidKorczynski
Copy link
Collaborator Author

/gcbrun exp -n d-cov-20 -b minor-for-ci -ns 2

@DavidKorczynski
Copy link
Collaborator Author

/gcbrun exp -n d-cov-21 -b minor-for-ci -ns 2

Signed-off-by: David Korczynski <[email protected]>
@DavidKorczynski
Copy link
Collaborator Author

/gcbrun skip

@DavidKorczynski
Copy link
Collaborator Author

Signed-off-by: David Korczynski <[email protected]>
@AdamKorcz AdamKorcz merged commit a666ac8 into main Sep 21, 2024
6 checks passed
@AdamKorcz AdamKorcz deleted the fix-cov-5 branch September 21, 2024 12:23
@DonggeLiu
Copy link
Collaborator

Could you please notify me of these changes?
Thanks!

@oliverchang
Copy link
Collaborator

Could you please notify me of these changes? Thanks!

+1 Please add us on PRs that modify core functionality such as these :) This is just in case we have anything else WIP that clashes.

DavidKorczynski added a commit that referenced this pull request Sep 25, 2024
Introduced following the addition of textcov to the workdir in
#638

This caused reports to individual benchmarks run to have wrong links,
e.g.
https://llm-exp.oss-fuzz.com/Result-reports/ofg-pr/2024-09-21-638-d-cov-21-minor-for-ci/benchmark/output-htslib-bcf_index_build/index.html

Signed-off-by: David Korczynski <[email protected]>
DavidKorczynski added a commit that referenced this pull request Sep 25, 2024
Introduced following the addition of textcov to the workdir in
#638

This caused reports to individual benchmarks run to have wrong links,
e.g.

https://llm-exp.oss-fuzz.com/Result-reports/ofg-pr/2024-09-21-638-d-cov-21-minor-for-ci/benchmark/output-htslib-bcf_index_build/index.html

---------

Signed-off-by: David Korczynski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants