Add integration tests for nftables package #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stapelberg
requested changes
Jan 14, 2025
There was a problem hiding this comment.
Thanks! I originally thought “wait, we already have such an integration test!”, but then I realized it’s not in this repository: The test I had in mind was https://github.com/rtr7/router7/blob/master/integration/netconfig/netconfig_test.go from https://router7.org/
Just a few small changes, very nice overall!
aojea
force-pushed
the
tests
branch
3 times, most recently
from
0f08738 to
29e428e
Compare
Change-Id: Ie90d72f48e42c9d896ba302685352295efacc099 Signed-off-by: Antonio Ojea <[email protected]>
|
addressed comments |
stapelberg
approved these changes
Jan 15, 2025
stapelberg
requested changes
Jan 15, 2025
This commit adds integration tests to the nftables package to verify that the Go code correctly programs nftables rules. The tests use external nftables scripts to define the expected state and compare it with the state produced by the Go code. Change-Id: I9c8439ee462b4882b221e6244f53379b822446dc Signed-off-by: Antonio Ojea <[email protected]>
stapelberg
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds integration tests to the nftables package to verify
that the Go code correctly programs nftables rules. The tests use
external nftables scripts to define the expected state and compare
it with the state produced by the Go code.