Extract out ProgressPrinter
#1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a preparation before supporting 'clang-cl' for Windows (google#1179). Our plan is to download LLVM for Windows in 'update_deps.py', and in that process we would like to use 'ProgressPrinter' to show progress for both downloading the archive and extracting it. To avoid code duplicate between 'build_qt.py' and 'update_deps.py', let's extract 'ProgressPrinter' into a new file first. This is a mechanical refactoring commit. There must be no observable behavior change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a preparation before supporting
clang-clfor Windows (#1179).Our plan is to download LLVM for Windows in
update_deps.py, and in that process we would like to useProgressPrinterto show progress for both downloading the archive and extracting it.To avoid code duplicate between
build_qt.pyandupdate_deps.py, let's extractProgressPrinterinto a new file first.This is a mechanical refactoring commit. There must be no observable behavior change.
Issue IDs
clang-clto build Mozc for Windows with Bazel #1179Steps to test new behaviors (if any)
build_qt.pyandupdate_deps.pywork as they used to.