Skip to content

Commit

Permalink
Fix missing product_icon.ico target and visibility
Browse files Browse the repository at this point in the history
This follow up to my previous commit [1], which aimed to start
supporting Mozc installer for Windows with Bazel (#948).

There were a missing target and visibility. With this commit it should
finally start working.

 [1]: ffc460e

PiperOrigin-RevId: 680454012
  • Loading branch information
yukawa authored and hiroyuki-komatsu committed Sep 30, 2024
1 parent 6c61c4f commit b92c4fd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/data/images/win/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,8 @@ filegroup(
srcs = glob(["*.ico"]),
visibility = ["//win32/tip:__subpackages__"],
)

exports_files(
srcs = ["product_icon.ico"],
visibility = ["//:__subpackages__"],
)
1 change: 1 addition & 0 deletions src/win32/installer/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -178,4 +178,5 @@ genrule(
tools = [
":build_installer",
],
visibility = ["//:__subpackages__"],
)

0 comments on commit b92c4fd

Please sign in to comment.